Implement ml_meth as an union. #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejrs
commented
Feb 13, 2022
birkenfeld
reviewed
Feb 14, 2022
|
Thanks, this does look a bit nicer than the transmutes. I think this needs a |
mejrs
commented
Feb 14, 2022
Comment on lines
-79
to
-82
| impl Default for PyMethodDef { | ||
| fn default() -> PyMethodDef { | ||
| unsafe { mem::zeroed() } | ||
| } |
There was a problem hiding this comment.
I don't think this default impl makes sense if PyMethodDefPointer is never null.
There was a problem hiding this comment.
Agreed; I also actually generally don't like having any implementations of traits or methods for pyo3-ffi types if possible (except for Copy & Clone). Makes it closer to the C that they come from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2129