Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require a working Python interpreter when generate-abi3-import-lib feature is enabled for Windows #879

Merged
merged 2 commits into from
Apr 17, 2022
Merged

Don't require a working Python interpreter when generate-abi3-import-lib feature is enabled for Windows #879

merged 2 commits into from
Apr 17, 2022

Conversation

messense
Copy link
Member

@messense messense commented Apr 16, 2022 •
edited
Loading

Ref #830

@netlify
Copy link

netlify bot commented Apr 16, 2022 •
edited
Loading

✅ Deploy Preview for maturin-guide canceled.

Name Link
🔨 Latest commit b9655d1
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/625b883b4a8a7100086de4fb

@messense messense mentioned this pull request Apr 16, 2022
Merged
@messense
Copy link
Member Author

cc @ravenexp

@ravenexp
Copy link
Contributor

Oh, right, this makes it possible to omit the useless -i python argument when cross-compiling to Windows and PYO3_CROSS_LIB_DIR is not set. Does this also work in the native Windows-to-Windows compilation case when there's no Python interpreter on the system?

@messense
Copy link
Member Author

Does this also work in the native Windows-to-Windows compilation case when there's no Python interpreter on the system?

I haven't test it on Windows yet, thanks for the reminder.

@konstin
Copy link
Member

konstin commented Apr 16, 2022

😍

Note that you should also update the message at

maturin/src/build_options.rs

Line 729 in 045a120

println!("🐍 Not using a specific python interpreter (With abi3, an interpreter is only required on windows)");

@messense messense force-pushed the generate-abi3-import-lib branch from 3e7bba1 to 8da44a9 Compare April 16, 2022 11:12
@messense messense added the CI-no-fail-fast If one job fails, allow the rest to keep testing label Apr 16, 2022
@messense messense force-pushed the generate-abi3-import-lib branch 2 times, most recently from eba07dc to 6df9df4 Compare April 16, 2022 12:10
@messense messense marked this pull request as ready for review April 16, 2022 12:33
@messense messense removed the CI-no-fail-fast If one job fails, allow the rest to keep testing label Apr 16, 2022
@messense messense force-pushed the generate-abi3-import-lib branch from 6df9df4 to af4f307 Compare April 17, 2022 03:21
messense added 2 commits April 17, 2022 11:23
@messense
Don't require a working Python interpreter when `generate-abi3-import…
7d1b63b 
…-lib` feature is enabled for Windows
@messense
Look for pyo3 crate first for generate-abi3-import-lib feature
b9655d1 
pyo3-ffi doesn't have `generate-abi3-import-lib` feature yet.
@messense messense force-pushed the generate-abi3-import-lib branch from af4f307 to b9655d1 Compare April 17, 2022 03:23
@messense messense changed the title Don't require a working Python interpreter when generate-abi3-import-lib feature is enabled on Windows Don't require a working Python interpreter when generate-abi3-import-lib feature is enabled for Windows Apr 17, 2022
@messense messense merged commit 17d4a30 into PyO3:main Apr 17, 2022
@messense messense deleted the generate-abi3-import-lib branch April 17, 2022 03:43
@messense messense linked an issue Apr 17, 2022 that may be closed by this pull request
Better support for cross compiling to Windows #830
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better support for cross compiling to Windows
3 participants
@messense @ravenexp @konstin