Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for building on Windows mingw platforms #677

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Add support for building on Windows mingw platforms #677

merged 2 commits into from
Nov 16, 2021

Conversation

messense
Copy link
Member

Fixes #676

@netlify
Copy link

netlify bot commented Nov 14, 2021 •
edited
Loading

✔️ Deploy Preview for maturin-guide canceled.

🔨 Explore the source changes: c5a122d

🔍 Inspect the deploy log: https://app.netlify.com/sites/maturin-guide/deploys/6192760dfbb3de0008342bea

@messense messense force-pushed the mingw branch 2 times, most recently from d5279ad to 465c79e Compare November 14, 2021 02:25
@messense
Copy link
Member Author

To properly support mingw we'd also need to consider platform tag from sysconfig.get_platfrom() not just hard code to win32/win_amd64/win_arm64.

This was referenced Nov 14, 2021
Open
Closed
@messense messense merged commit 0133fc8 into PyO3:main Nov 16, 2021
@messense messense deleted the mingw branch November 16, 2021 09:01
@messense messense mentioned this pull request Nov 17, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with abiflags check for Python3 under MINGW64
1 participant
@messense