Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Description metadata difference in upload command #520

Merged
merged 1 commit into from
May 1, 2021

Conversation

messense
Copy link
Member

@messense messense commented Apr 28, 2021

Fixes #518

cc @ravenexp

@messense messense force-pushed the upload-ignore-desc-diff branch from 15f3ea3 to d89ee1d Compare April 28, 2021 12:48
@ravenexp
Copy link
Contributor

ravenexp commented May 1, 2021

LGTM as a fix for #518, but I'm afraid similar issues may arise in the future... Ideally, the current limitation of all uploaded wheels sharing the same metadata should be lifted.

As a way forward, the upload_ui() function have to be extended allow every uploaded wheel to supply its own set of metadata.
I'll try to implement this change myself and send a new PR some time soon.
This fix should be merged in the meantime.

@messense messense merged commit 278f9de into PyO3:main May 1, 2021
@messense messense deleted the upload-ignore-desc-diff branch May 1, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload fails with erroneous "different python packages" error
2 participants