Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building for musl libc #423

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Fix building for musl libc #423

merged 1 commit into from
Feb 17, 2021

Conversation

messense
Copy link
Member

Closes #154

@messense
Copy link
Member Author

cc @thedrow

@konstin
Copy link
Member

konstin commented Feb 17, 2021

Thank you!

@konstin konstin merged commit c8107b8 into PyO3:master Feb 17, 2021
@messense messense deleted the musl-no-crt-static branch February 17, 2021 10:06
@messense
Copy link
Member Author

Seems that -C target-feature=-crt-static breaks https://github.com/PyO3/maturin/runs/1918499503

@konstin
Copy link
Member

konstin commented Feb 17, 2021

Yeah, I've overlooked that it needs to be guarded on libraries only. Should be fixed in 53dd4c2

@messense messense mentioned this pull request Apr 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to install pyo3-pack on Alpine Linux
2 participants
@messense @konstin