Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unmaintained fs2 with fs4 #2317

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Replace unmaintained fs2 with fs4 #2317

merged 3 commits into from
Nov 26, 2024

Conversation

messense
Copy link
Member

No description provided.

@messense
Copy link
Member Author

messense commented Nov 25, 2024

This change is part of the following stack:

Change managed by git-spice.

@messense messense force-pushed the fs4 branch 3 times, most recently from 1de677d to 75c0060 Compare November 25, 2024 12:00
@messense
Copy link
Member Author

@konstin any idea why cffi venv related tests always fail on Windows?

@konstin
Copy link
Member

konstin commented Nov 26, 2024

not sure, sorry, i can try to debug on windows later if the errors persist.

@messense
Copy link
Member Author

Found the culprit:

maturin/src/target.rs

Lines 633 to 644 in ea2e54e

let bin_dir = venv.join("Scripts");
if bin_dir.join("python.exe").exists() {
return bin_dir;
}
// Python installed via msys2 on Windows might produce a POSIX-like venv
// See https://github.com/PyO3/maturin/issues/1108
let bin_dir = venv.join("bin");
if bin_dir.join("python.exe").exists() {
return bin_dir;
}
// for conda environment
venv.to_path_buf()

get_venv_bin_dir can only works correctly with a existing venv on Windows.

@messense messense enabled auto-merge (squash) November 26, 2024 12:56
@messense messense merged commit 0ee5e80 into main Nov 26, 2024
38 checks passed
@messense messense deleted the fs4 branch November 26, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants