Enable --all-features when building source distribution
#2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
When building sdist, `cargo metadata` command should output all dependencies including optional ones, otherwise the resulting sdist file may not compile when building with optional features activated. Enabling `--all-features` ensure that all optional path dependencies to be packaged into sdist, which should help with #2117.
messense
force-pushed
the
build-sdist-with-all-features
branch
from
c79bdfc
to
523a7fd
Compare
2 tasks
2 tasks
danking
added a commit
to spiraldb/vortex
that referenced
this pull request
Sep 10, 2024
Fixes #771. Eliminates the hack from #748 which worked around PyO3/maturin#2215.
robert3005
pushed a commit
to spiraldb/vortex
that referenced
this pull request
Sep 10, 2024
…772) Fixes #771. Eliminates the hack from #748 which worked around PyO3/maturin#2215.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building sdist,
cargo metadatacommand should output all dependencies including optional ones, otherwise the resulting sdist file may not compile when building with optional features activated.Enabling
--all-featuresensure that all optional path dependencies to be packaged into sdist, which should help with #2117.