Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize REPOSITORY_URL #2206

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Conversation

austin362667
Copy link
Contributor

Normalize URLs before comparison to ensure consistent matching, regardless of trailing slashes.

This approach standardizes the URLs by either consistently adding or removing the trailing slash, allowing for flexible and accurate comparisons irrespective of user input.

For example,

const TEST_REPOSITORY_URL: &'static str = "https://test.pypi.org/legacy/";

should be the same as

const TEST_REPOSITORY_URL: &'static str = "https://test.pypi.org/legacy";

no matter there's a trailing slash at the end of url or not.

Signed-off-by: Austin Liu <[email protected]>
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for maturin-guide ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3c8e77d
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/66d58f87ab87dd0008b73905
😎 Deploy Preview https://deploy-preview-2206--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/upload.rs Outdated Show resolved Hide resolved
src/upload.rs Outdated Show resolved Hide resolved
src/upload.rs Outdated Show resolved Hide resolved
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@messense messense merged commit 9a4c8b7 into PyO3:main Sep 2, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants