Place source dist readmes next to Cargo.toml #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
konstin
force-pushed
the
konsti/fix-readme-position
branch
2 times, most recently
from
0b9360a
to
91d13dc
Compare
Place source dist readmes next to Cargo.toml `package.readme` may point to any point above the package, so when we move the directory, but keep the readme position, we could get different readme files at the same archive location. To solves this, we rewrite `Cargo.toml` to find the readme in the same directory and add the readme to this directory.
konstin
force-pushed
the
konsti/fix-readme-position
branch
from
91d13dc
to
0592bd9
Compare
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package.readmemay point to any point above the package, so when we move the directory, but keep the readme position, we could get different readme files at the same archive location. To solves this, we rewriteCargo.tomlto find the readme in the same directory and add the readme to this directory.Fixes #2154