-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't check .gitignore files in parent directories #2158
Conversation
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
e0740d1
to
ead72bb
Compare
c3427e5
to
74cff9b
Compare
I'm not sure about disabling git global excludes, I often put things in it (like |
Hmm, why would those be getting picked up in the build though? They shouldn't be part of the package paths right? |
By the way any idea why tests are failing on windows? I don't really have a windows system set up for testing right now. |
Probably because the disk is full. |
no, it's because this change breaks something because it's not ignoring a
|
cc575a2
to
396c492
Compare
What's the correct way to get the directory containing |
ac0b8d8
to
e080ca3
Compare
29f30ea
to
f5d8dfd
Compare
8b452cb
to
570b5bd
Compare
I think I have this fixed(along with some other random issues such as windows path length issues). |
When building inside a .gitignore'd output directory as part of another build system maturin may accidentially pick up the parent .gitignore. Lets just disable searching for parent .gitignore files since this functionality is broken anyways as the logic does not match git's .gitignore logic anyways. For example in buildroot we have an output directory that has its contents gitignored in which maturin will build packages, changing some minor implementation details in how we ignore this directory triggered this bug. buildroot/buildroot@a14c862 As the output dir files are supposed to be ignored both before and after this change this indicates that ignore::WalkBuilder parent matching is fundamentally broken and can not be used reliably in the first place as it does not match git's ignore logic. Also disable git exclude and git global excludes which may cause problems. Signed-off-by: James Hilliard <[email protected]>
570b5bd
to
e0db05c
Compare
@messense Does this look ok to merge? The only test failure I'm seeing appears to be spurious. |
When building inside a .gitignore'd output directory as part of another build system maturin may accidentially pick up the parent .gitignore. Lets just disable searching for parent .gitignore files since this functionality is broken anyways as the logic does not match git's .gitignore logic anyways.
For example in buildroot we have an output directory that has its contents gitignored in which maturin will build packages, changing some minor implementation details in how we ignore this directory triggered this bug.
buildroot/buildroot@a14c862
As the output dir files are supposed to be ignored both before and after this change this indicates that ignore::WalkBuilder parent matching is fundamentally broken and can not be used reliably in the first place as it does not match git's ignore logic.
Also disable git exclude and git global excludes which may cause problems.