Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base executable when possible in PEP 517 build #2094

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Use base executable when possible in PEP 517 build #2094

merged 1 commit into from
Jun 2, 2024

Conversation

messense
Copy link
Member

@netlify Netlify
Copy link

netlify bot commented May 31, 2024 •
edited
Loading

✅ Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit fcd43c1
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/6659812e0cce8c00080b25f0
😎 Deploy Preview https://deploy-preview-2094--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@messense messense linked an issue May 31, 2024 that may be closed by this pull request
Make it possible to skip passing --interpreter option when building editable wheels via pep517 backend #1896
Closed
konstin
konstin approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a smart trick

@messense messense added this pull request to the merge queue May 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 31, 2024
@messense messense merged commit 9a2d4f6 into PyO3:main Jun 2, 2024
28 checks passed
@messense messense deleted the pep517-use-base-executable branch June 2, 2024 10:08
@messense messense mentioned this pull request Jun 5, 2024
Merged
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstin konstin konstin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it possible to skip passing --interpreter option when building editable wheels via pep517 backend
2 participants
@messense @konstin