Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in pep517 build default compatibility to off instead of always specifying #1992

Merged
merged 5 commits into from
Mar 14, 2024

Conversation

altendky
Copy link
Contributor

I specified 2014 via MATURIN_PEP517_ARGS but the duplicate specification resulted in this error

https://github.com/Chia-Network/chia_rs/actions/runs/8253603665/job/22575880171?pr=428#step:8:578

💥 maturin failed
  Caused by: Expected only one platform tag but found 2
Error: command ['maturin', 'pep517', 'build-wheel', '-i', '/tmp/build-env-g63n6la_/bin/python', '--compatibility', 'off', '--compatibility', '2014'] returned non-zero exit status 1

I'll go test this PR against that and see if it works.

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 3abbad7
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/65f24d3b0bcbb10008c03500
😎 Deploy Preview https://deploy-preview-1992--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@altendky
Copy link
Contributor Author

failure seems unrelated, being outside the org i can't rerun single jobs so i'll close and reopen.

@altendky altendky closed this Mar 13, 2024
@altendky altendky reopened this Mar 13, 2024
@altendky
Copy link
Contributor Author

Using this PR in the same test as failed above worked. https://github.com/Chia-Network/chia_rs/actions/runs/8255383741/job/22581737015?pr=428

@altendky
Copy link
Contributor Author

Same odd error on Windows, FYI.

https://github.com/PyO3/maturin/actions/runs/8270312519/job/22627553656?pr=1992#step:17:662

FileNotFoundError: [Errno 2] No such file or directory: '\\\\?\\D:\\a\\maturin\\maturin\\test-crates\\venvs\\develop-cffi-pure-cpython\\Lib\\site-packages\\pip\\.\\py.typed'

@altendky altendky closed this Mar 13, 2024
@altendky altendky reopened this Mar 13, 2024
maturin/__init__.py Outdated Show resolved Hide resolved
@messense messense marked this pull request as ready for review March 14, 2024 01:05
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@messense messense merged commit 1c4a4e6 into PyO3:main Mar 14, 2024
28 of 29 checks passed
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Mar 29, 2024
https://build.opensuse.org/request/show/1163373
by user mia + anag+factory
- Update to 1.5.1
  * fix changelog link
    gh#PyO3/maturin#1990
  * in pep517 build default compatibility to off instead of always specifying
    gh#PyO3/maturin#1992
  * Fix typo on maturin docs
    gh#PyO3/maturin#1997
  * Fix upload returning malformed summary error
    gh#PyO3/maturin#2002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants