Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about incorrect version in build-system.requires #1793

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

konstin
Copy link
Member

@konstin konstin commented Oct 2, 2023

Maturin should warn if the version in the pyproject.toml build system requirements is incompatible with the one that is currently running (#1792). We only warn instead of erroring to allow e.g. testing a prerelease version of maturin with a project without having to edit the requires.

pyproject.toml:

[build-system]
requires = ["maturin==0.0.1"]
build-backend = "maturin"

Output:

⚠️  Warning: You specified maturin ==0.0.1 in pyproject.toml under `build-system.requires`, but the current maturin version is 1.2.3

Fixes #1792.

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 7bed4bc
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/651ab95d8db89100084b34dc
😎 Deploy Preview https://deploy-preview-1793--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@messense messense merged commit 846724f into main Oct 2, 2023
33 checks passed
@messense messense deleted the warning-incorrect-version branch October 2, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build command ignores build-system.requires specifier
2 participants