Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set PYO3_PYTHON if interpreter is runnable regardless of abi3 #1592

Merged
merged 1 commit into from
May 6, 2023

Conversation

messense
Copy link
Member

@messense messense commented May 6, 2023

It can be useful in build scripts, like pyca/cryptography#8815 (comment)

@messense messense added the bindings/pyo3 pyo3 bindings label May 6, 2023
@netlify
Copy link

netlify bot commented May 6, 2023

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 084111f
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/64564b4d5f6f51000944d3cc
😎 Deploy Preview https://deploy-preview-1592--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense
Copy link
Member Author

messense commented May 6, 2023

bors r+

bors bot added a commit that referenced this pull request May 6, 2023
1592: Always set `PYO3_PYTHON` if interpreter is runnable regardless of abi3 r=messense a=messense

It can be useful in build scripts, like pyca/cryptography#8815 (comment)

Co-authored-by: messense <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 6, 2023

Build failed:

@messense messense force-pushed the abi3-interpreter branch from b4e9e2d to 41298d7 Compare May 6, 2023 12:10
@messense
Copy link
Member Author

messense commented May 6, 2023

bors retry

bors bot added a commit that referenced this pull request May 6, 2023
1592: Always set `PYO3_PYTHON` if interpreter is runnable regardless of abi3 r=messense a=messense

It can be useful in build scripts, like pyca/cryptography#8815 (comment)

Co-authored-by: messense <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 6, 2023

Build failed:

@messense messense force-pushed the abi3-interpreter branch from 41298d7 to 084111f Compare May 6, 2023 12:42
@messense
Copy link
Member Author

messense commented May 6, 2023

bors retry

@bors
Copy link
Contributor

bors bot commented May 6, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 8af9efe into PyO3:main May 6, 2023
@messense messense deleted the abi3-interpreter branch May 6, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings/pyo3 pyo3 bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant