Use pep440_rs and pep508_rs #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
konstin
commented
Apr 2, 2023
| ] | ||
|
|
||
| [[package]] | ||
| name = "pep508_rs" |
There was a problem hiding this comment.
effectively this only adds only one new dependency
konstin
commented
Apr 2, 2023
| operator: MarkerOperator::Equal, | ||
| r_value: MarkerValue::QuotedString(extra_value), | ||
| }) if &extra_value == extra => None, | ||
| MarkerTree::And(and) => match &*and { |
There was a problem hiding this comment.
not sure how to deal with the borrow checker better here without vec patterns
konstin
commented
Apr 2, 2023
| @@ -61,6 +64,42 @@ pub struct Metadata21 { | |||
| pub entry_points: IndexMap<String, IndexMap<String, String>>, | |||
| } | |||
|
|
|||
| impl Metadata21 { | |||
| /// Initializes with name, version and otherwise the defaults | |||
| pub fn new(name: String, version: Version) -> Self { | |||
There was a problem hiding this comment.
Since Version does not have a default
konstin
commented
Apr 2, 2023
| (min_python_minor..=MAXIMUM_PYPY_MINOR).map(|minor| format!("pypy3.{minor}")), | ||
| (min_python_minor..=MAXIMUM_PYPY_MINOR) | ||
| .filter(|minor| { | ||
| requires_python |
There was a problem hiding this comment.
this is some duplication unfortunately
bors bot
added a commit
that referenced
this pull request
Apr 3, 2023
1558: Use pep440_rs and pep508_rs r=messense a=konstin This switches from string heuristics to proper PEP 440 and PEP 508 parsing. This includes full support for `requires-python`, extra handling and wasmtime detection. Co-authored-by: konstin <[email protected]>
|
Build failed: |
This was referenced May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from string heuristics to proper PEP 440 and PEP 508 parsing. This includes full support for
requires-python, extra handling and wasmtime detection.