Move maturin metadata from Cargo.toml to pyproject.toml
#1493
Conversation
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
messense
force-pushed
the
package-metadata-maturin
branch
from
6977ea4 to
2b5f3a3
Compare
src/pyproject_toml.rs
Outdated
| @@ -86,6 +86,8 @@ impl GlobPattern { | |||
| #[serde(rename_all = "kebab-case")] | |||
| pub struct ToolMaturin { | |||
| // maturin specific options | |||
| // extension module name, accepts setuptools style import name like `foo.bar` | |||
| name: Option<String>, | |||
There was a problem hiding this comment.
I feel that name isn't a good name for this, how about extension-name / extension-module?
There was a problem hiding this comment.
yeah, maybe rust-module-name or native-module-name? i think extension a bit misleading because in maturin's case it's not an extension, it's the main thing (and the metaphor of extending cpython by adding new built-in modules is lost on most users)
There was a problem hiding this comment.
I think module-name is a good alternative.
messense
force-pushed
the
package-metadata-maturin
branch
2 times, most recently
from
7681fea to
1782939
Compare
|
What does this pull request need to be ready to be merged? |
Use `tool.maturin.data` of `pyproject.toml` instead.
messense
force-pushed
the
package-metadata-maturin
branch
from
1782939 to
1332779
Compare
…e` in `pyproject.toml`
messense
force-pushed
the
package-metadata-maturin
branch
from
1332779 to
0b5311e
Compare
|
Yeah, I'd also like to release a new 0.14 version to deprecate |
|
sounds good! i also thought about publishing a v0.15 first so people can test all the breaking changes and then publish a 1.0 two weeks or so later |
…` in `pyproject.toml`
|
bors r=konstin |
|
Build succeeded: |
Implements #1489 (comment)