-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom TLS certificate authority bundle #1483
Conversation
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@aalekhpatel07 can you give this a try? You need to clone my branch and run |
4c4e445
to
4c7b1fe
Compare
7fc608e
to
5b42294
Compare
* Custom TLS CA can be configured via one of the `MATURIN_CA_BUNDLE`, `REQUESTS_CA_BUNDLE` and `CURL_CA_BUNDLE` env vars.
5b42294
to
57193fc
Compare
I've tested this locally and it seems working, so I'm going to merge it now, feel free to open a new issue if it somehow doesn't work for you. bors r+ |
That sounds excellent. Thanks for your work on this PR! My apologies, I haven't gotten around to testing in my dev env yet. I'll create an issue if the problem persists, as you suggested. Wondering if you'd know the version of the release with this patch. |
I'll release a new 1.0.0 beta version for testing, then you can install it via |
That'd be wonderful. Thanks again! |
Build succeeded: |
@aalekhpatel07 A new beta is out in PyPI: https://pypi.org/project/maturin/1.0.0b2/ |
Custom TLS CA can be configured via one of the
MATURIN_CA_BUNDLE
,REQUESTS_CA_BUNDLE
andCURL_CA_BUNDLE
env vars.Closes #1418