Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom TLS certificate authority bundle #1483

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

messense
Copy link
Member

@messense messense commented Feb 14, 2023

Custom TLS CA can be configured via one of the MATURIN_CA_BUNDLE, REQUESTS_CA_BUNDLE and CURL_CA_BUNDLE env vars.

Closes #1418

@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 57193fc
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/63eca44f4744d10008093241
😎 Deploy Preview https://deploy-preview-1483--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense added the breaking-change Breaking change label Feb 14, 2023
@messense messense added this to the 1.0.0 milestone Feb 14, 2023
@messense
Copy link
Member Author

@aalekhpatel07 can you give this a try? You need to clone my branch and run cargo run upload path/to/wheel.whl with one of the MATURIN_CA_BUNDLE, REQUESTS_CA_BUNLDE and CURL_CA_BUNDLE env var.

@messense messense force-pushed the custom-ca-bundle branch 3 times, most recently from 4c4e445 to 4c7b1fe Compare February 14, 2023 11:16
@messense messense removed the breaking-change Breaking change label Feb 14, 2023
@messense messense force-pushed the custom-ca-bundle branch 2 times, most recently from 7fc608e to 5b42294 Compare February 14, 2023 11:37
@messense messense marked this pull request as ready for review February 14, 2023 12:33
* Custom TLS CA can be configured via one of the
  `MATURIN_CA_BUNDLE`, `REQUESTS_CA_BUNDLE` and `CURL_CA_BUNDLE` env vars.
@messense
Copy link
Member Author

I've tested this locally and it seems working, so I'm going to merge it now, feel free to open a new issue if it somehow doesn't work for you.

bors r+

@messense messense mentioned this pull request Feb 16, 2023
7 tasks
@aalekhpatel07
Copy link

That sounds excellent. Thanks for your work on this PR!

My apologies, I haven't gotten around to testing in my dev env yet. I'll create an issue if the problem persists, as you suggested.

Wondering if you'd know the version of the release with this patch.

@messense
Copy link
Member Author

Wondering if you'd know the version of the release with this patch.

I'll release a new 1.0.0 beta version for testing, then you can install it via pip install -U --pre maturin.

@aalekhpatel07
Copy link

That'd be wonderful. Thanks again!

@bors
Copy link
Contributor

bors bot commented Feb 16, 2023

@bors bors bot merged commit 6a16f7f into PyO3:main Feb 16, 2023
@messense messense deleted the custom-ca-bundle branch February 16, 2023 07:33
@messense
Copy link
Member Author

@aalekhpatel07 A new beta is out in PyPI: https://pypi.org/project/maturin/1.0.0b2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable support for custom SSL certs when publishing.
2 participants