Check path-like interpreter arguments when cross compiling #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 3, 2023
1459: Check path-like interpreter arguments when cross compiling r=messense a=messense For example: `maturin build -m test-crates/pyo3-mixed/Cargo.toml -i ./python3.10 --target aarch64-unknown-linux-gnu`, where `./python3.10` doesn't exists Before ```bash 🍹 Building a mixed python/rust project 🔗 Found pyo3 bindings 💥 maturin failed Caused by: Unsupported Python interpreter: /python3.10 ``` After ```bash 🍹 Building a mixed python/rust project 🔗 Found pyo3 bindings 💥 maturin failed Caused by: /python3.10 is not a valid python interpreter ``` Or it exists but isn't runnable: Before ```bash 🍹 Building a mixed python/rust project 🔗 Found pyo3 bindings 💥 maturin failed Caused by: Unsupported Python interpreter: /Users/messense/Downloads/python/bin/python3.10 ``` After ```bash 🍹 Building a mixed python/rust project 🔗 Found pyo3 bindings /Users/messense/Downloads/python/bin/python3.10: /Users/messense/Downloads/python/bin/python3.10: cannot execute binary file 💥 maturin failed Caused by: Trying to get metadata from the python interpreter '/Users/messense/Downloads/python/bin/python3.10' failed ``` Co-authored-by: messense <[email protected]>
|
Build failed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
maturin build -m test-crates/pyo3-mixed/Cargo.toml -i ./python3.10 --target aarch64-unknown-linux-gnu, where./python3.10doesn't exists:Before
After
Or it exists but isn't runnable:
Before
After
🍹 Building a mixed python/rust project 🔗 Found pyo3 bindings /Users/messense/Downloads/python/bin/python3.10: /Users/messense/Downloads/python/bin/python3.10: cannot execute binary file 💥 maturin failed Caused by: Trying to get metadata from the python interpreter '/Users/messense/Downloads/python/bin/python3.10' failedSee also #1433 (comment)