Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't package dev-only path dependencies in sdist #1435

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

messense
Copy link
Member

When building from sdist, cargo only needs dependencies and build-dependencies, removing dev-dependencies entirely from Cargo.toml makes sdist size smaller and avoid some problems with dev-only path deps like #1083 (comment).

@messense messense added the sdist Source distribution label Jan 30, 2023
@messense messense requested a review from konstin January 30, 2023 02:09
@netlify
Copy link

netlify bot commented Jan 30, 2023

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 0f64240
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/63d72dc2cacd190009d4cd69
😎 Deploy Preview https://deploy-preview-1435--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense force-pushed the rm-dev-dependencies-from-sdist branch from 1e9cfa5 to 0f64240 Compare January 30, 2023 02:38
@messense
Copy link
Member Author

bors r=konstin

@bors
Copy link
Contributor

bors bot commented Jan 30, 2023

@bors bors bot merged commit 7b19fa0 into PyO3:main Jan 30, 2023
@messense messense deleted the rm-dev-dependencies-from-sdist branch January 30, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdist Source distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants