Use the extension_name in develop builds #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same now as for non-develop builds. If a user sets `package.metadata.maturin` the import in other Python files will reference that name. For develop builds to also work it needs to have the same name.
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks, can you share an example that doesn't work currently for future reference? bors r+ |
|
Build succeeded: |
Sure thing: https://github.com/badboy/maturin-uniffi-hello-world |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same now as for non-develop builds.
If a user sets
package.metadata.maturinthe import in other Python files will reference that name.For develop builds to also work it needs to have the same name.
At least in a local build for me this makes it work as expected. Not sure if that breaks others now though.