Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with --no-default-features by default when bootstrapping from sdist #1333

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

messense
Copy link
Member

@messense messense commented Dec 5, 2022

Cargo features can be customized with the MATURIN_SETUP_ARGS env var, for example:

export MATURIN_SETUP_ARGS="--features upload"
python setup.py bdist_wheel

The above command will override --no-default-features and pass --features upload instead.

Closes #1306

@messense messense added distros-packaging Something related to distros packaging breaking-change Breaking change labels Dec 5, 2022
@netlify
Copy link

netlify bot commented Dec 5, 2022

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 79aaf9e
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/638e0423f7ae050009b4625c
😎 Deploy Preview https://deploy-preview-1333--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

… sdist

Cargo features can be customized with the `MATURIN_SETUP_ARGS` env var, for example:

```
export MATURIN_SETUP_ARGS="--features upload"
python setup.py bdist_wheel
```

The above command will override `--no-default-features` and pass `--features upload` instead.
@messense messense force-pushed the setup-no-default-features branch from ba80503 to 79aaf9e Compare December 5, 2022 14:45
@messense
Copy link
Member Author

messense commented Dec 5, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 5, 2022

@bors bors bot merged commit 1e09e2f into PyO3:main Dec 5, 2022
@messense messense deleted the setup-no-default-features branch December 5, 2022 15:54
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request May 8, 2023
https://build.opensuse.org/request/show/1085456
by user mia + dimstar_suse
- Update to v0.15.1:
  * Use shlex to split MATURIN_SETUP_ARGS
    gh#PyO3/maturin#1595
  * Fix finding interpreters from bundled sysconfigs
    gh#PyO3/maturin#1598
- Changes in v0.15.0:
  * Feature gate zig and xwin based cross compiling
    gh#PyO3/maturin#1324
  * Feature gate maturin new and maturin init commands
    gh#PyO3/maturin#1330
  * Build with --no-default-features
    gh#PyO3/maturin#1333
  * Support SOURCE_DATE_EPOCH environment variable in wheel
    building
    gh#PyO3/maturin#1334
  * Remove deprecated config options
    gh#PyO3/maturin#1335
  * cargo deny multiple crate versions
    gh#PyO3/maturin#1336
  * Replace rpassword with dialoguer
    gh#PyO3/maturin#1338
  * Fix sdist when all Cargo workspace members are excluded
    gh#PyO3/maturin#1343
  * Update normpath to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Breaking change distros-packaging Something related to distros packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce compile time when build maturin from source distribution
1 participant