Fix wrong platform tag when building in i386 docker container on x86_64 host #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
messense
force-pushed
the
docker-i386
branch
from
659c617
to
1ac2be1
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 27, 2022
1301: Fix wrong platform tag when building in i386 docker container r=messense a=messense Fixes the i386 issue reported in #1289 (comment). We can not trust the return value of `uname -m` in Docker container. Co-authored-by: messense <[email protected]>
GitHub Actions can't run properly: OCI runtime exec failed: exec failed: unable to start container process: exec /__e/node16_alpine/bin/node: no such file or directory: unknown
|
Canceled. |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Nov 27, 2022
1301: Fix wrong platform tag when building in i386 docker container r=messense a=messense Fixes the i386 issue reported in #1289 (comment). We can not trust the return value of `uname -m` in Docker container. Co-authored-by: messense <[email protected]>
messense
changed the title
|
bors seems stuck. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Dec 2, 2022
https://build.opensuse.org/request/show/1039390 by user mia + dimstar_suse - Update to v0.14.3: * Bump MSRV to 1.62.0 gh#PyO3/maturin#1297 * CI: Run ruff in lint jobs gh#PyO3/maturin#1298 * Fix build error when required features of bin target isn't enabled gh#PyO3/maturin#1299 * Build and publish armv6l wheels for maturin gh#PyO3/maturin#1300 * Fix wrong platform tag when building in i386 docker container on x86_64 host gh#PyO3/maturin#1301 * Fix wrong platform tag when building in armv7 docker container on aarch64 host gh#PyO3/maturin#1303 * CI: Stop caching test crates target directory gh#PyO3/maturin#1302 * refactor: Use clap_complete_command gh#PyO3/maturin#1304 * Remove human-panic dependency gh#PyO3/maturin#1305 * chore: cargo update to remove rustix 0.35.x gh#PyO3/maturin#1307 * chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the i386 issue reported in #1289 (comment).
We can not trust the return value of
uname -min Docker container.