Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default manifest path for maturin sdist command #1097

Merged
merged 1 commit into from
Sep 11, 2022
Merged

Remove default manifest path for maturin sdist command #1097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Fix sdist build for optional path dependencies in [#1084](https://github.com/PyO3/maturin/pull/1084)
* auditwheel: find dylibs in Cargo target directory in [#1092](https://github.com/PyO3/maturin/pull/1092)
* Add library search paths in Cargo target directory to rpath in editable mode on Linux in [#1094](https://github.com/PyO3/maturin/pull/1094)
* Remove default manifest path for `maturin sdist` command in [#1097](https://github.com/PyO3/maturin/pull/1097)

## [0.13.2] - 2022-08-14

Expand Down
11 changes: 3 additions & 8 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,9 @@ enum Opt {
/// This command is a workaround for [pypa/pip#6041](https://github.com/pypa/pip/issues/6041)
#[clap(name = "sdist")]
SDist {
#[clap(
short = 'm',
long = "manifest-path",
parse(from_os_str),
default_value = "Cargo.toml"
)]
#[clap(short = 'm', long = "manifest-path", parse(from_os_str))]
/// The path to the Cargo.toml
manifest_path: PathBuf,
manifest_path: Option<PathBuf>,
/// The directory to store the built wheels in. Defaults to a new "wheels"
/// directory in the project's target directory
#[clap(short, long, parse(from_os_str))]
Expand Down Expand Up @@ -413,7 +408,7 @@ fn run() -> Result<()> {
let build_options = BuildOptions {
out,
cargo: CargoOptions {
manifest_path: Some(manifest_path),
manifest_path,
..Default::default()
},
..Default::default()
Expand Down