Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find pyproject.toml in parent directories of Cargo.toml #1054

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Find pyproject.toml in parent directories of Cargo.toml #1054

merged 2 commits into from
Aug 11, 2022

Conversation

messense
Copy link
Member

@messense messense commented Aug 10, 2022 •
edited
Loading

When --manifest-path is supplied via cli, lookup pyproject.toml
in its parent directories until workspace root.

Fixes #1053

@netlify
Copy link

netlify bot commented Aug 10, 2022 •
edited
Loading

✅ Deploy Preview for maturin-guide canceled.

Name Link
🔨 Latest commit 62f1650
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/62f499ac45d39a0008e010b6

@messense messense force-pushed the find-pyproject-toml branch from 8ba713b to 8094640 Compare August 10, 2022 09:19
@messense messense mentioned this pull request Aug 10, 2022
Closed
2 tasks
@messense messense marked this pull request as draft August 10, 2022 09:40
messense
messense commented Aug 10, 2022
View reviewed changes
src/project_layout.rs Outdated Show resolved Hide resolved
@messense messense force-pushed the find-pyproject-toml branch 3 times, most recently from 3568ff7 to 708818c Compare August 10, 2022 14:00
@messense messense added the CI-no-fail-fast If one job fails, allow the rest to keep testing label Aug 11, 2022
@messense messense force-pushed the find-pyproject-toml branch 3 times, most recently from 168f00a to d409808 Compare August 11, 2022 05:44
@messense
Find pyproject.toml in parent directories of Cargo.toml
488de98 
When `--manifest-path` is supplied via cli, lookup `pyproject.toml`
in its parent directories until workspace root.
@messense
CI: run tests with RUST_BACKTRACE=1
62f1650
@messense messense force-pushed the find-pyproject-toml branch from d409808 to 62f1650 Compare August 11, 2022 05:54
@messense messense removed the CI-no-fail-fast If one job fails, allow the rest to keep testing label Aug 11, 2022
@messense messense marked this pull request as ready for review August 11, 2022 07:18
@messense messense merged commit 8c1aa72 into PyO3:main Aug 11, 2022
@messense messense deleted the find-pyproject-toml branch August 11, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependencies not added to the wheel metadata
1 participant
@messense