Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find python module next to pyproject.toml if pyproject.toml exists #1044

Merged
merged 1 commit into from
Aug 7, 2022

Conversation

messense
Copy link
Member

@messense messense commented Aug 7, 2022

Based on #1043.

The primary motivation for this is to make pyxel buildable with maturin.

$ tree -L 2
.
├── CHANGELOG.md
├── LICENSE
├── Makefile
├── README.md
├── lib
│   ├── Cargo.lock
│   ├── Cargo.toml
│   ├── Makefile
│   ├── engine
│   ├── pyoxidizer.bzl
│   ├── pyxel.vbs
│   ├── rustfmt.toml
│   ├── setup.iss
│   ├── target
│   ├── update_version
│   └── wrapper
├── pyproject.toml
├── pyxel
│   ├── __init__.py
│   ├── __init__.pyi
│   ├── __main__.py
│   ├── cli.py
│   ├── editor
│   ├── examples
│   ├── lib
│   └── py.typed
├── setup.cfg
└── setup.py

@netlify
Copy link

netlify bot commented Aug 7, 2022

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit dc3a59f
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/62efdbc8545e5500084a9b26
😎 Deploy Preview https://deploy-preview-1044--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense marked this pull request as ready for review August 7, 2022 15:36
@messense messense merged commit d4ac36f into PyO3:main Aug 7, 2022
@messense messense deleted the project-root branch August 7, 2022 16:01
messense added a commit to messense/maturin that referenced this pull request Aug 8, 2022
Now that project root is changed to the directory containing
`pyproject.toml` in PyO3#1044, `python-source` specified in `Cargo.toml`
should be treated as relative to `Cargo.toml`.

We should also change `data` to do the same.
messense added a commit to messense/maturin that referenced this pull request Aug 8, 2022
Now that project root is changed to the directory containing
`pyproject.toml` in PyO3#1044, `python-source` specified in `Cargo.toml`
should be treated as relative to `Cargo.toml`.

We should also change `data` to do the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant