Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to either update docs or update installer to ensure users have patchelf #766

Closed
Peddle opened this issue Jan 7, 2022 · 1 comment
Closed

Need to either update docs or update installer to ensure users have patchelf #766

Peddle opened this issue Jan 7, 2022 · 1 comment
Labels
documentation Documentation needs improvement

Comments

@Peddle
Copy link

Peddle commented Jan 7, 2022 •
edited
Loading

Not sure the right way to go (documentation or automation) but looks like as of this PR: #742, we need to have patchelf installed otherwise I get this error when running maturin build --release

💥 maturin failed
  Caused by: Failed to execute 'patchelf', did you install it?
  Caused by: No such file or directory (os error 2)

(tested on 0.12.6)
@messense messense added the documentation Documentation needs improvement label Jan 7, 2022
@messense
Copy link
Member

messense commented Jan 7, 2022 •
edited
Loading

Just need to document it. Without #742 maturin build will fail with auditwheel error since you have external shared library dependencies.

messense added a commit that referenced this issue Jan 7, 2022
@messense
Add a patchelf optional dependency to python maturin package
71a0087 
Helps with #766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Documentation needs improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@messense @Peddle