Clarification on the manylinux wheels comliance

[rth]

Thanks for this very useful package!

Regarding building manylinux1 wheels, the readme states,

The pypa offers a special docker container and a tool called auditwheel to ensure compliance with the manylinux rules. pyo3-pack contains a reimplementation of the most important part of auditwheel that checks the generated library, so there's no need to use external tools. If you want to disable the manylinux compliance checks for some reason, use the --skip-auditwheel flag.

As far as I understand, another requirement of the manylinux policy is that it needs to work with CentOS 5.11 (on which those docker images are based). Does it mean that one has to use these docker images (and install rust nightly there)? The readme sounds like it's not necessary...

[konstin]

In theory, rust should only link symbols old enough for manylinux compliance. iirc in there's a bug where rust currently links two more recent symbols, breaking manylinux and even manylinux2010 compliance. Unfortunately I currently can't check because the latest nightly crashes in the manylinux container with some error about the gcc version: rust-lang/rust#56849. So this means you currently need the docker container for full compliance; I had started creating a Dockerfile with all tools installed, but not finished it.

[rth]

Thanks for the explanations @konstin !

[konstin]

I've filed rust-lang/rust#57497 for glibc part, but I'm not sure if that will get fixed. I've also created a docker container based on the manylinux container with all required tools installed and published it under konstin2/pyo3-pack, but I think I need to pin the nightly, I don't know yet if tags get published and the upload feature can't be used (reqwest got rustls support just 3 days ago, maybe that could help, but that needs to be manually tested for regressions).

[konstin]

I've improved the Dockerfile a good bit and updated with proper information.

@rth Could have a look at the readme please and tell me if that fixes the issue?

[rth]

yes 5375271 fixes this issue, thanks @konstin !

[ijl]

@konstin should konstin2/pyo3-pack be public? I need to login to access it.

[konstin]

Thanks for the note @ijl, I've changed it to the correct link.