Merge pull request #1338 from messense/dialoguer-password

Replace `rpassword` with `dialoguer`

Cargo.toml

@@ -79,7 +79,6 @@ minijinja = { version = "0.26.0", optional = true }
 bytesize = { version = "1.0.1", optional = true }
 configparser = { version = "3.0.0", optional = true }
 multipart = { version = "0.18.0", features = ["client"], default-features = false, optional = true }
-rpassword = { version = "7.0.0", optional = true }
 ureq = { version = "2.3.1", features = ["gzip", "socks-proxy"], default-features = false, optional = true }
 native-tls-crate = { package = "native-tls", version = "0.2.8", optional = true }
 keyring = { version = "1.1.1", optional = true }
@@ -97,7 +96,7 @@ full = ["cross-compile", "log", "scaffolding", "upload"]
 
 log = ["tracing-subscriber"]
 
-upload = ["ureq", "multipart", "rpassword", "configparser", "bytesize"]
+upload = ["ureq", "multipart", "configparser", "bytesize", "dialoguer/password"]
 # keyring doesn't support *BSD so it's not enabled in `full` by default
 password-storage = ["upload", "keyring"]
 

src/upload.rs

@@ -141,14 +141,17 @@ fn get_password(_username: &str) -> String {
         };
     }
 
-    rpassword::prompt_password("Please enter your password: ").unwrap_or_else(|_| {
-        // So we need this fallback for pycharm on windows
-        let mut password = String::new();
-        io::stdin()
-            .read_line(&mut password)
-            .expect("Failed to read line");
-        password.trim().to_string()
-    })
+    dialoguer::Password::new()
+        .with_prompt("Please enter your password")
+        .interact()
+        .unwrap_or_else(|_| {
+            // So we need this fallback for pycharm on windows
+            let mut password = String::new();
+            io::stdin()
+                .read_line(&mut password)
+                .expect("Failed to read line");
+            password.trim().to_string()
+        })
 }
 
 fn get_username() -> String {