-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle code guarded by 'if TYPE_CHECKING' correctly #530
Closed
Commits on Apr 15, 2020
-
Omit code guarded by 'if TYPE_CHECKING'
This commit finds a problem that has been observed in read code. Consider the following code: ``` from typing import TYPE_CHECKING ... if TYPE_CHECKING from a import A, B from b import C ... def f() -> "B": ... def f() # Oops! C is actually used here. C() ``` This commit ignores all code that is guarded by TYPE_CHECKING in order to find mistakes like this. This constant is always False when mypy is not running anyway.
Configuration menu - View commit details
-
Copy full SHA for 44aab70 - Browse repository at this point
Copy the full SHA 44aab70View commit details -
Configuration menu - View commit details
-
Copy full SHA for d66aeb8 - Browse repository at this point
Copy the full SHA d66aeb8View commit details
Commits on Apr 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3b60143 - Browse repository at this point
Copy the full SHA 3b60143View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6f0dd2 - Browse repository at this point
Copy the full SHA a6f0dd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b938b2b - Browse repository at this point
Copy the full SHA b938b2bView commit details
Commits on Apr 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3474adf - Browse repository at this point
Copy the full SHA 3474adfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8e687a - Browse repository at this point
Copy the full SHA b8e687aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a30cfcb - Browse repository at this point
Copy the full SHA a30cfcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7306c2b - Browse repository at this point
Copy the full SHA 7306c2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12fd45a - Browse repository at this point
Copy the full SHA 12fd45aView commit details -
Configuration menu - View commit details
-
Copy full SHA for aeaf0b6 - Browse repository at this point
Copy the full SHA aeaf0b6View commit details
Commits on Apr 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f5657ba - Browse repository at this point
Copy the full SHA f5657baView commit details -
Configuration menu - View commit details
-
Copy full SHA for a993d91 - Browse repository at this point
Copy the full SHA a993d91View commit details
Commits on May 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7eb8484 - Browse repository at this point
Copy the full SHA 7eb8484View commit details
Commits on Mar 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a9d4a7f - Browse repository at this point
Copy the full SHA a9d4a7fView commit details
Commits on Mar 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 558914b - Browse repository at this point
Copy the full SHA 558914bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbe214a - Browse repository at this point
Copy the full SHA cbe214aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.