Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.0 is broken #422

Closed
ThomasWaldmann opened this issue Jan 30, 2019 · 6 comments
Closed

2.1.0 is broken #422

ThomasWaldmann opened this issue Jan 30, 2019 · 6 comments

Comments

@ThomasWaldmann
Copy link

https://travis-ci.org/borgbackup/borg/jobs/486513787

@asottile
Copy link
Member

while this isn't a very quality bug report it gave me enough information to find a minimal reproduction. @ThomasWaldmann in the future it would be good to include the stacktrace, the project, the version information, etc. in the issue (even the filename if you could identify it)

I've managed to boil this down to a minimal case:

x = lambda f: f

@x
def t():
    pass

y = lambda f: f

@x
@y
def t():
    pass

@x
@y
def t():
    pass

@asottile
Copy link
Member

#423 has a fix for this

@ThomasWaldmann
Copy link
Author

@asottile thanks for fixing. any idea about ETA for 2.1.1 release?

@sigmavirus24
Copy link
Member

That's a question for @bitglue, grumpy cat @ThomasWaldmann

@ThomasWaldmann
Copy link
Author

Update: besides failing all our travis-ci test runs, it also hangs flake8 in our local vagrant-based test setup, see link directly above.

@untitaker
Copy link
Contributor

I reproduced this with the following, and can confirm it's fixed in master. This is affecting our builds as well.

def bar(x):
    return x


@bar
def foo():
    pass


def foo():
    pass

In the meantime we're installing from master.

untitaker added a commit to untitaker/pyflakes that referenced this issue Feb 21, 2019
myint pushed a commit that referenced this issue May 4, 2019
* Add another test for #422

* remove old test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants