Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal Python 3.7 #2064

Merged
merged 5 commits into from
Jan 3, 2023
Merged

Removal Python 3.7 #2064

merged 5 commits into from
Jan 3, 2023

Conversation

staticdev
Copy link
Collaborator

@staticdev staticdev commented Dec 30, 2022 •
edited
Loading

  • Removes almost EOL Py3.7.
  • Uses importlib.metadata for versions.
  • Remove unnecessary _future module.
  • Update documentation.
  • Small cleanups on lint.sh.

@codecov
Copy link

codecov bot commented Dec 30, 2022 •
edited
Loading

Codecov Report

Merging #2064 (64c983e) into main (b20228c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2064   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files          38       38           
  Lines        3084     3085    +1     
  Branches      745      745           
=======================================
+ Hits         3047     3048    +1     
  Misses         26       26           
  Partials       11       11

timothycrosley
timothycrosley approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@timothycrosley timothycrosley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I agree it's reasonable to drop ongoing support for Python <= 3.7 at this time

@staticdev staticdev merged commit 03a9949 into main Jan 3, 2023
@staticdev staticdev deleted the removal/python-3.7 branch January 3, 2023 20:32
@vedantpuri vedantpuri mentioned this pull request Jan 29, 2023
Closed
@svillegas-cdd svillegas-cdd mentioned this pull request Feb 6, 2023
Merged
regisb added a commit to overhangio/tutor that referenced this pull request Feb 9, 2023
@regisb
chore: upgrade reqs for python 3.7
bda4e0a 
Unfortunately, previous reqs upgrade was not compatible with python 3.7
because isort dropped support for that "almost EOL" version:
PyCQA/isort#2064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothycrosley timothycrosley timothycrosley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staticdev @timothycrosley