Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test case and fix for cython pure python import #2063

Merged
merged 2 commits into from
Dec 27, 2022

Conversation

jtoledo1974
Copy link
Contributor

Here is a test case demostrating the issue. I'll try to produce a patch as well.

@jtoledo1974
Copy link
Contributor Author

Added fix for the test case that fixes #2062

@jtoledo1974 jtoledo1974 changed the title Added test case for cython pure python import Added test case and fix for cython pure python import Dec 27, 2022
@staticdev
Copy link
Collaborator

@jtoledo1974 thank you for the fix. Just curious, in your first commit adding the test it does not fail in CI. It should, right?

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #2063 (9b37e89) into main (98390f5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2063   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files          38       38           
  Lines        3084     3084           
  Branches      745      745           
=======================================
  Hits         3047     3047           
  Misses         26       26           
  Partials       11       11           

@jtoledo1974
Copy link
Contributor Author

@jtoledo1974 thank you for the fix. Just curious, in your first commit adding the test it does not fail in CI. It should, right?

In my fork of isort from master, the first commit that added the test was failing (it was turning the import into a cimport). With the second commit that adds the fix the test does not fail.

I'm not sure if that is what you were asking, though.

@staticdev staticdev merged commit ff29175 into PyCQA:main Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants