Skip to content

Commit

Permalink
Update stage names for pre-commit
Browse files Browse the repository at this point in the history
`pre-commit` v4.0.0 added a warning to deprecated stage names[1] so
update these names to avoid the warning. This also required updating the
minimum `pre-commit` version to one that supports the new names

See also[2] for a similar change and the docs[3].

[1] https://github.com/pre-commit/pre-commit/blob/cc4a52241565440ce200666799eef70626457488/CHANGELOG.md#400---2024-10-05
[2] pre-commit/pre-commit-hooks@003dfa5
[3] https://pre-commit.com/#confining-hooks-to-run-at-certain-stages

Fixes: #2294
  • Loading branch information
matthewhughes934 committed Oct 10, 2024
1 parent 7de1829 commit 4eeb37a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .pre-commit-hooks.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
- id: isort
name: isort
entry: isort
stages: [commit, merge-commit, push, manual]
stages: [pre-commit, pre-merge-commit, pre-push, manual]
require_serial: true
language: python
types_or: [cython, pyi, python]
args: ['--filter-files']
minimum_pre_commit_version: '2.9.2'
minimum_pre_commit_version: '3.2.0'

0 comments on commit 4eeb37a

Please sign in to comment.