require python 3.6 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently flake8-pyi only works on 3.6 because I put a variable annotation somewhere in pyi.py by accident. That's easy to fix, but I think we should require 3.6 only anyway, because several typeshed stubs now also use PEP 526-style annotations.
I tried to work around the problem by hacking flake8 to use typed-ast to parse stubs, but that doesn't really work because flake8 gets confused when it gets a typed_ast.ast3.Store instead of an ast.Store. I suppose we could translate the typed-ast AST to an ast AST, but life is too short for that.
Related: python/mypy#3398.