remove Y092 #88
remove Y092 #88
Conversation
Disabled-by-default error codes are problematic; see #75. Y092 finds a fairly harmless error and has significant false positives (python/typeshed#6930). I'm removing it so we can get rid of disabled-by-default errors and simplify our setup.
|
Why not just make it turned on by default, and use |
|
I feel like the signal-to-noise ratio is too low. Checks that need to be disabled half the time they trigger aren't useful. And that argument becomes stronger when the benefit of enabling the check is lower, and there is very little benefit to removing the |
That's an awful lot of |
|
Apart from typing and typing_extensions, this seems to be the only use case where I have seen lots of typeshed reviews where the reviewer (usually srittau, sometimes someone else I think) mentions about |
|
python/typeshed#6930 has two possible approaches for getting rid of the false positives. |
Half of what exactly? Typeshed contains relatively few occurrences of |
|
I'm not too happy about this, since this is a poster-child for a linter check. This is something I need to manually check and complain about, which should be handled by a linter. That said, since we're not using the check in typeshed at the moment, and due to the practical problems with it, I'm okay with removing it for now, although we should leave an issue for eventual re-adding it. |
|
Feel free to remove, once merge conflict is fixed :) |
Disabled-by-default error codes are problematic; see #75.
Y092 finds a fairly harmless error and has significant false positives (python/typeshed#6930).
I'm removing it so we can get rid of disabled-by-default errors and simplify our
setup.