Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update URL handling functions #152

Merged
merged 5 commits into from
Jan 19, 2023
Merged

fix: update URL handling functions #152

merged 5 commits into from
Jan 19, 2023

Conversation

weibullguy
Copy link
Member

This PR re-writes the URL handling function so it no longer puts URLs back together after wrapping. Rather it find the URLs in the long description and handles them individually and separately from the remainder of the description.

Closes #145
Closes #150
Closes #151

@weibullguy weibullguy self-assigned this Jan 19, 2023
@weibullguy weibullguy added P: bug PEP 257 violation or existing functionality that doesn't work as documented C: style Relates to docstring format style (e.g., Google, NumPy, Sphinx) V: patch Bumps the patch version labels Jan 19, 2023
@coveralls
Copy link

coveralls commented Jan 19, 2023

Pull Request Test Coverage Report for Build 3954862858

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 3868116968: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@weibullguy weibullguy merged commit 917fed9 into master Jan 19, 2023
@weibullguy weibullguy deleted the fix/issue-145 branch January 19, 2023 18:05
@weibullguy weibullguy added the S: merged Closed with work merged to repository label Jan 20, 2023
@weibullguy weibullguy restored the fix/issue-145 branch January 24, 2023 20:10
@weibullguy weibullguy deleted the fix/issue-145 branch January 24, 2023 20:11
@weibullguy weibullguy removed the V: patch Bumps the patch version label Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: style Relates to docstring format style (e.g., Google, NumPy, Sphinx) P: bug PEP 257 violation or existing functionality that doesn't work as documented S: merged Closed with work merged to repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexError: list index out of range on pre-commit URL formatting error Error when URL is the last line
2 participants