Switch to tox 4 #1020
Merged
Switch to tox 4 #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove `skipsdist = True` (tox 4 will not install bandit with this setting, not even in editable mode for environments where `usedevelop = True` is set), add `skip_install = true` to the pep8 job
- remove `requires = tox<4`
- use multi-line list for `passenv`
- add the `-` mark to ignore pylint exit code in the pep8 job - although this mark is already present in `[testenv:pylint]`, tox 4 ignores it when using the `{[testenv:pylint]commands}` substitution
In tox 4, environments should always be specified using the -e flag to the `run` subcommand. https://tox.wiki/en/4.4.11/upgrading.html#updating-usage-with-e
mportesdev
requested review from
ericwb,
lukehinds and
sigmavirus24
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a few adjustments to achieve compatibility with tox 4.
Update tox.ini to work with tox 4
skipsdist = True(tox 4 will not install bandit with this setting, not even in editable mode for environments whereusedevelop = Trueis set), addskip_install = trueto the pep8 jobrequires = tox<4passenv-mark to ignore pylint exit code in the pep8 job - although this mark is already present in[testenv:pylint], tox 4 ignores it when using the{[testenv:pylint]commands}substitutionUse the
tox runcommand in GitHub ActionsIn tox 4, environments should always be specified using the -e flag to the
runsubcommand. https://tox.wiki/en/4.4.11/upgrading.html#updating-usage-with-e