Adds check for crypt module usage as weak hash #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crypt module also permits creating weak hashes such as MD5 just like hashlib. This change extends the hashlib plugin to add the extra checks on calls to crypt.crypt and crypt.mksalt which both take a hash method parameter. The new checks won't necessarily catch all weak hashes available as the operating system might provide others that the crypt module picks up. But it will capture cases with the default set. Namely, METHOD_CRYPT", METHOD_MD5, and METHOD_BLOWFISH. Also note that crypt.methods is supposed to return a list all available hash methods. However, testing has shown that it can return just METHOD_CRYPT, the weakest of the bunch. And passing None as args to these module functions will default to the highest available hash from crypt.methods. So this also can be weak by default, but no reliable for Bandit to detect. https://docs.python.org/3.11/library/crypt.html#module-crypt Fixes PyCQA#1017 Signed-off-by: Eric Brown <[email protected]>
sigmavirus24
approved these changes
Apr 10, 2023
charliermarsh
pushed a commit
to astral-sh/ruff
that referenced
this pull request
Mar 11, 2024
…S605` (#10313) ## Summary Pick up updates made in latest [releases](https://github.com/PyCQA/bandit/releases) of `bandit`: - `S311`: PyCQA/bandit#940 and PyCQA/bandit#1096 - `S324`: PyCQA/bandit#1018 - `S605`: PyCQA/bandit#1116 ## Test Plan Snapshot tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crypt module also permits creating weak hashes such as MD5 just like hashlib. This change extends the hashlib plugin to add the extra checks on calls to
crypt.cryptandcrypt.mksaltwhich both take a hash method parameter.The new checks won't necessarily catch all weak hashes available as the operating system might provide others that the crypt module picks up. But it will capture cases with the default set. Namely,
METHOD_CRYPT,METHOD_MD5, andMETHOD_BLOWFISH.Also note that crypt.methods is supposed to return a list all available hash methods. However, testing has shown that it can return just
METHOD_CRYPT, the weakest of the bunch. And passing None as args to these module functions will default to the highest available hash fromcrypt.methods. So this also can be weak by default, but no reliable for Bandit to detect.https://docs.python.org/3.11/library/crypt.html#module-crypt
Fixes #1017