Stopped using pkg_resources, as it's deprecated. #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replacement is the
packagingmodule, but it's not exactly the same. It provides aRequirementobject but it's different from the previous one, and there's noDependencyso to match versions we need to play withRequirement.specifiers.The
VCSDependencyobject we had grew in complexity, as it needs a newVCSSpecifierto mimic the newRequirement. Similarly, I added aNameVerDependencyto be able to compare objects with name and version.While working on this I found that in
check_pypi_updateswe were comparing versions as strings ("2.3" is greater than "1.3", but it is smaller than "10.2"... and if you compare the strings that is broken). I added a test for this and fixed it by usingpackaging.Versionwhich compare as they should.Finally, I removed all traces of "setuptools" and "pkg_resources" as a dependency needed to run.