Patch/pxweb2 154 update chromatic to v11 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we want to keep the project up-yo-date, we need to update packages that have breaking changes. The Chromatic v11+ breaking change has to do with TurboSnap, and a new check for setting/telling the cli the baseDir for storybook. Since we do not use TurboSnap, and only used 1500 of our 5000 free snapshots last month. Adding this can be done later, when we need to look at ways to optimize the build process. Or we can drop it entirely if we can upgrade our Chromatic project account to an Open Source one. Though we still might want to do it just to not be wasteful.
Deploying pxweb2 with
|
| Latest commit: |
29de1a2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ac873d41.pxweb2.pages.dev |
| Branch Preview URL: | https://patch-pxweb2-154-update-chro.pxweb2.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we want to keep the project up-yo-date, we need to update packages
that have breaking changes. The Chromatic v11+ breaking change has to do
with TurboSnap, and a new check for setting/telling the cli the baseDir
for storybook.
Since we do not use TurboSnap, and only used 1500 of our 5000 free
snapshots last month. Adding this can be done later, when we need to
look at ways to optimize the build process. Or we can drop it
entirely if we can upgrade our Chromatic project account to an Open
Source one. Though we still might want to do it just to not be wasteful.