Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pxweb2 149 common text styling #78

Merged
merged 8 commits into from
Apr 4, 2024

Conversation

PerIngeVaaje
Copy link
Contributor

Make use of text-styles in common scss

Copy link

cloudflare-workers-and-pages bot commented Mar 18, 2024

Deploying pxweb2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: e87d9de
Status: ✅  Deploy successful!
Preview URL: https://e81ee110.pxweb2.pages.dev
Branch Preview URL: https://feature-pxweb2-149-common-te.pxweb2.pages.dev

View logs

MikaelNordberg
MikaelNordberg previously approved these changes Mar 22, 2024
Copy link
Contributor

@MikaelNordberg MikaelNordberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@SjurSutterudSagen SjurSutterudSagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We probably want more feedback on the placement of the text-styles.scss file next to the global.scss file. But it makes sense to me.

@PerIngeVaaje PerIngeVaaje marked this pull request as ready for review April 4, 2024 12:05
Copy link
Contributor

@SjurSutterudSagen SjurSutterudSagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PerIngeVaaje PerIngeVaaje merged commit 95c7fa4 into main Apr 4, 2024
7 checks passed
@PerIngeVaaje PerIngeVaaje deleted the feature/PXWEB2-149-Common-text-styling branch April 4, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants