Feature/pxweb2 63 add global breakpoint tokens #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we need to control the layout for different sized screens and such, we need the breakpoints for the media queries. This commit adds the breakpoints to a file, and adds that to the style-dictionary build command. The same as how we define and use the Spacings. In this way we have 1 place where all the breakpoint values are set, and can change them or add to them later if needed.
Since we want to see the breakpoints working, this commit adds an example to the main app page. One thing to consider is that currently the breakpoint tokens are imported (@use) from the files that are generated in the ui lib, and not from inside the app itself. I am not sure if we want this, or to create another set of files inside the app's own folder, and import from there. This is very easy to add in our current implementation, just add another output file to the build.js in the lib.
Improves how the scss is imported. This commit adds the alias '$ui' to the pxweb2 app's vite config, which can be used to import from the pxweb2-ui lib in a cleaner way than traversing the filesystem with '../..'. Co-authored-by: Michael Pande <>
Deploying with
|
| Latest commit: |
888b7b3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0af07605.pxweb2.pages.dev |
| Branch Preview URL: | https://feature-pxweb2-63-add-global.pxweb2.pages.dev |
SjurSutterudSagen
deleted the
feature/PXWEB2-63-add-global-breakpoint-tokens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we need to control the layout for different sized screens and such, we need the breakpoints for the media queries. This commit adds the breakpoints to a file, and adds that to the style-dictionary build command. The same as how we define and use the Spacings. In this way we have 1 place where all the breakpoint values are set, and can change them or add to them later if needed.
One thing to consider is that currently the breakpoint tokens are imported (@use) from the files that are generated in the ui lib, and not from inside the main app itself. I am not sure if we want this, or to create another set of files inside the app's own folder, and import from there. This is very easy to add in our current implementation, just add another output file to the build.js in the lib. And update the .gitignore if we don't want them committed to the repo.
Also added an example of the breakpoints working to the main app.