Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pxweb2 46 link #66

Merged
merged 10 commits into from
Apr 5, 2024
Merged

Feature/pxweb2 46 link #66

merged 10 commits into from
Apr 5, 2024

Conversation

PerIngeVaaje
Copy link
Contributor

No description provided.

… class for icons. Added properties for inline and noUnderline
…nd would propably not be used.

Made css simpler. possible without icon left inline

Added padding for standalone links to meet WCAG requirements.

Set smaller gap for links with icon.  2px for standalone and 0px for inline
Copy link

cloudflare-workers-and-pages bot commented Mar 13, 2024

Deploying pxweb2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 00588ca
Status: ✅  Deploy successful!
Preview URL: https://e5d91537.pxweb2.pages.dev
Branch Preview URL: https://feature-pxweb2-46-link-take2.pxweb2.pages.dev

View logs

…arents.

Removed stories showing combination not to be used

Added classes for BosyLong medium /small. Should be moved to common text-styles class
@PerIngeVaaje PerIngeVaaje marked this pull request as ready for review April 3, 2024 11:34
Copy link
Contributor

@SjurSutterudSagen SjurSutterudSagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MikaelNordberg MikaelNordberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@PerIngeVaaje PerIngeVaaje merged commit fadccd0 into main Apr 5, 2024
7 checks passed
@PerIngeVaaje PerIngeVaaje deleted the feature/PXWEB2-46-link-take2 branch April 5, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants