Feature/pxweb2 99 formatting numbers based on language #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add basic formatting for numbers. We are still looking into custom decimals instead of specific hardcoded formats. Co-authored-by: Mikael Nordberg <>
Add an example of how to override the formatting options, so we can have other decimal numbers or rounding modes than what is specified in the translation.json file. This also gives us the ability to set the options based on a variable. The next step is to look into turning this into a component to be reused, so we can have global settings for the options. Co-authored-by: Mikael Nordberg <>
Since we want to format numbers based on the language chosen, we need to add this to the project. The basic functionality was added when i18next was installed, but we have added examples for how to use this in a few different ways. We noticed that a basic example led to many places to set the roundingMode, and therefore created a function and a cusstom formatter for i18next, where we set this roundingMode based on a variable. This prepares the number formatting for the work to be done later, with a config file for the project. Co-authored-by: Mikael Nordberg <>
|
The issue we ran into with TypeScript and "roundingMode" missing in the type for intl.NumberFormatOptions is solved microsoft/TypeScript#52072. But this is not yet available in the released ts version, as of now. |
SjurSutterudSagen
deleted the
feature/PXWEB2-99-formatting-numbers-based-on-language
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we want to format numbers based on the language chosen, we need to
add this to the project. The basic functionality was added when i18next
was installed, but we have added examples for how to use this in a few
different ways.
We noticed that a basic example led to many places to set the
roundingMode, and therefore created a function and a custom formatter
for i18next, where we set this roundingMode based on a variable. This
prepares the number formatting for the work to be done later, with a
config file for the project.
Co-authored-by: Mikael Nordberg [email protected]