Feature/pxweb2-41 install i18next #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we want to support multiple languages in the application, we need to add translation files for the languages we want to support. We also need to add a configuration file for i18next, which is the library we use for translations.
Since site administrators may want to change translations we cannot cache the translation files.
Since we need to support right-to-left languages, we need to implement support for document direction. We also added arabic as a language, since we need an rtl language. We did not add plurals or numbers or date support yet. Mikael Nordberg <>
Since we want to support changing how dates are formatted, we need to set that up with i18next. This commit adds only a very basic date formatter, but it might be enough. Mikael Nordberg <>
Add a date formatted with both the date and the time of day. Mikael Nordberg <>
Add a basic suspense component around the App, to show loading state for requests the server makes. Co-authored-by: Mikael Nordberg <>
Deploying with
|
| Latest commit: |
8f6daae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6e7b5056.pxweb2.pages.dev |
| Branch Preview URL: | https://feature-pxweb2-41-install-i1.pxweb2.pages.dev |
Since the date formatting works the same in all languages, we do not need separate date formatting for different languages. i18next uses the right one even if it is only specified in the fallback language.
likp
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds language functionality to the app. More specifically, this PR adds support for languages, language files, ability to change document direction to support right-to-left languages and basic date formatting.
One thing to note is that we turned off caching of the translation files for now. This was done because, if you deploy the app to an IIS server and edit the translation files, the caching stopped the page from updating with the new values.
There is more work to do when it comes to regions and formatting of dates/numbers. The challenge here is that the same language can have different formatting in different regions: 'en-US' vs 'en-CA' vs 'en-GB'. But i18n might default to just 'en' in some cases, and this can give inconsistent formatting.
This PR contains work for PXWEB2-41, PXWEB2-97 and PXWEB2-98.