Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXWEB2-34 Added option for icon left and icon right. Added stories. #41

Merged
merged 17 commits into from
Mar 5, 2024
Merged

PXWEB2-34 Added option for icon left and icon right. Added stories. #41

merged 17 commits into from
Mar 5, 2024

Conversation

PerIngeVaaje
Copy link
Contributor

Changed display from inline-felx to flex for .medium class

@PerIngeVaaje
PXWEB2-34 Added option for icon left and icon right. Added stories.
fd7af6b 
Changed display from inline-felx to flex for .medium class
@netlify Netlify
Copy link

netlify bot commented Feb 14, 2024 •
edited
Loading

✅ Deploy Preview for pxweb2 ready!

Name Link
🔨 Latest commit 4cd0c6f
🔍 Latest deploy log https://app.netlify.com/sites/pxweb2/deploys/65ddaf3299521900082fbc0f
😎 Deploy Preview https://deploy-preview-41--pxweb2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PerIngeVaaje
PXWEB2-34 Changed alert message in stories
43a9136
@PerIngeVaaje
PXWEB2-34 changed icon for icon left and right on button in story
be8ad6a
@PerIngeVaaje
PXWEB2-34
1b96e24 
-Set border-radius to 4px for small button on hover and active

-Use box-shadow instead of border to get "inset border" which will not increase button compares to button without border, Set Spread to 2px to get ticker "border",

-Set display to inline-flex as in Figma spec
@PerIngeVaaje
PXWEB2-34
6df5742 
Box shadow decreased from 2 to 1.5 px
Padding top/bottom 0.375 rem (6px) for small icons with text
Removed fixed with for small icons with text.
@PerIngeVaaje
PXWEB2-34
a20213a 
Separate classes for icon-only. Small button should have 4px(0.25rem) for left and right padding when having icon without text .
@PerIngeVaaje
PXWEB2-34 Set font-size to 14 px for small buttons
4cd0c6f
@PerIngeVaaje
PXWEB2-34 Ser line-height to 20px for small buttons
cb4c8fe
@PerIngeVaaje
PXWEB2-34 Added option for icon left and icon right. Added stories.
c6a0d67 
Changed display from inline-felx to flex for .medium class
@PerIngeVaaje
PXWEB2-34 Changed alert message in stories
dacd6fa
@PerIngeVaaje
PXWEB2-34 changed icon for icon left and right on button in story
188b0ed
@PerIngeVaaje
PXWEB2-34
3382d2a 
-Set border-radius to 4px for small button on hover and active

-Use box-shadow instead of border to get "inset border" which will not increase button compares to button without border, Set Spread to 2px to get ticker "border",

-Set display to inline-flex as in Figma spec
@PerIngeVaaje
PXWEB2-34
a4894a0 
Box shadow decreased from 2 to 1.5 px
Padding top/bottom 0.375 rem (6px) for small icons with text
Removed fixed with for small icons with text.
@PerIngeVaaje
PXWEB2-34
21b6a7f 
Separate classes for icon-only. Small button should have 4px(0.25rem) for left and right padding when having icon without text .
@PerIngeVaaje
PXWEB2-34 Set font-size to 14 px for small buttons
0d90d4a
@PerIngeVaaje
PXWEB2-34 Ser line-height to 20px for small buttons
10e2806
@PerIngeVaaje
Merge branch 'feature/PXWEB2-34-Button' of https://github.com/PxTools…
0337ae5 
…/PxWeb2 into feature/PXWEB2-34-Button
@PerIngeVaaje
Copy link
Contributor Author

Did a rebase to get latest changes from main after nx updating process. Only changes done in Button-folder as part of this pr.

SjurSutterudSagen
SjurSutterudSagen previously approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@SjurSutterudSagen SjurSutterudSagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PerIngeVaaje PerIngeVaaje dismissed SjurSutterudSagen’s stale review March 4, 2024 13:04

The merge-base changed after approval.

@MikaelNordberg MikaelNordberg marked this pull request as ready for review March 5, 2024 13:35
SjurSutterudSagen
SjurSutterudSagen previously approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@SjurSutterudSagen SjurSutterudSagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good

@PerIngeVaaje PerIngeVaaje dismissed SjurSutterudSagen’s stale review March 5, 2024 13:37

The merge-base changed after approval.

@SjurSutterudSagen SjurSutterudSagen self-requested a review March 5, 2024 13:39
SjurSutterudSagen
SjurSutterudSagen previously approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@SjurSutterudSagen SjurSutterudSagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I approve now?

MikaelNordberg
MikaelNordberg previously approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@MikaelNordberg MikaelNordberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@PerIngeVaaje PerIngeVaaje dismissed stale reviews from MikaelNordberg and SjurSutterudSagen March 5, 2024 13:48

The merge-base changed after approval.

@MikaelNordberg MikaelNordberg reopened this Mar 5, 2024
@SjurSutterudSagen SjurSutterudSagen self-requested a review March 5, 2024 13:55
MikaelNordberg
MikaelNordberg approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@MikaelNordberg MikaelNordberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MikaelNordberg MikaelNordberg merged commit ffef6e8 into main Mar 5, 2024
6 checks passed
@MikaelNordberg MikaelNordberg deleted the feature/PXWEB2-34-Button branch March 5, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikaelNordberg MikaelNordberg MikaelNordberg approved these changes

@SjurSutterudSagen SjurSutterudSagen Awaiting requested review from SjurSutterudSagen SjurSutterudSagen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PerIngeVaaje @SjurSutterudSagen @MikaelNordberg