Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chromatic path issue #403

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Fix chromatic path issue #403

merged 2 commits into from
Dec 4, 2024

Conversation

michaelpande
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 4, 2024 •
edited
Loading

Deploying pxweb2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: af080d0
Status: ✅  Deploy successful!
Preview URL: https://f64fb33d.pxweb2.pages.dev
Branch Preview URL: https://fix-chromatic-issue.pxweb2.pages.dev

View logs

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

SjurSutterudSagen
SjurSutterudSagen approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@SjurSutterudSagen SjurSutterudSagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get it merge so we can see if it works

@michaelpande michaelpande merged commit f6542dd into main Dec 4, 2024
12 checks passed
@michaelpande michaelpande deleted the fix-chromatic-issue branch December 4, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SjurSutterudSagen SjurSutterudSagen SjurSutterudSagen approved these changes

@likp likp Awaiting requested review from likp likp is a code owner

@MikaelNordberg MikaelNordberg Awaiting requested review from MikaelNordberg MikaelNordberg is a code owner

@KentMossback KentMossback Awaiting requested review from KentMossback KentMossback is a code owner

@runejo runejo Awaiting requested review from runejo runejo is a code owner

@PerIngeVaaje PerIngeVaaje Awaiting requested review from PerIngeVaaje PerIngeVaaje is a code owner

@JohannesFinsveen JohannesFinsveen Awaiting requested review from JohannesFinsveen

@oyessb oyessb Awaiting requested review from oyessb oyessb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelpande @SjurSutterudSagen