Fix building and testing on macs #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the Nx packages broke the build step on arm processors, due to the bug in npm with optional architecture dependencies. The same bug I've ran into several times when updating the Nx packages. This fixes those missing dependencies (had to delete node_modules and package-lock. Also, running the tests after removing Nx, in a clean repo, failed on TypeErrors with getTextBy. This adds a temporary fix by downgrading testing-library/react to the previous major version.
SjurSutterudSagen
requested review from
likp,
MikaelNordberg,
KentMossback,
runejo,
PerIngeVaaje,
JohannesFinsveen,
oyessb and
michaelpande
as code owners
|
michaelpande
approved these changes
Dec 2, 2024
|
Nice, this also fixed the new workflow in #379 👍 |
runejo
reviewed
Dec 3, 2024
| @@ -15,7 +15,8 @@ | |||
| "private": true, | |||
| "dependencies": { | |||
| "@uidotdev/usehooks": "^2.4.1", | |||
| "react-virtuoso": "^4.12.1" | |||
| "react-virtuoso": "^4.12.1", | |||
| "sass": "^1.81.0" | |||
There was a problem hiding this comment.
Should be under devDependencies.
Yesterday morning we talked about using https://www.npmjs.com/package/sass-embedded is it a better option? @michaelpande @SjurSutterudSagen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the Nx packages broke the build step on arm processors, due to the bug in npm with optional architecture dependencies. The same bug I've ran into several times when updating the Nx packages. This fixes those missing dependencies (had to delete node_modules and package-lock.
Also, running the tests after removing Nx, in a clean repo, failed on TypeErrors with getTextBy. This adds a temporary fix by downgrading testing-library/react to the previous major version.