Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nx #374

Merged
merged 22 commits into from
Nov 28, 2024
Merged

Remove nx #374

merged 22 commits into from
Nov 28, 2024

Conversation

michaelpande
Copy link
Contributor

Removed Nx from most places, there are still some places left. Where we use nx as a plugin or nx/react or stuff like that. Making this PR to get errors in the build steps in order to get closer to something that can be merged.

After it is merged the rest can easier be handled.

The worry is that the longer this task isn't merged the worse the merge will be. It's guaranteed to be pretty horrific already 🙈

Copy link

cloudflare-workers-and-pages bot commented Nov 28, 2024

Deploying pxweb2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 218cbd7
Status: ✅  Deploy successful!
Preview URL: https://e3912703.pxweb2.pages.dev
Branch Preview URL: https://remove-nx.pxweb2.pages.dev

View logs

PerIngeVaaje
PerIngeVaaje previously approved these changes Nov 28, 2024
Copy link
Contributor

@PerIngeVaaje PerIngeVaaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

MikaelNordberg
MikaelNordberg previously approved these changes Nov 28, 2024
Copy link
Contributor

@MikaelNordberg MikaelNordberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine

Copy link
Contributor

@MikaelNordberg MikaelNordberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@michaelpande michaelpande merged commit 80290aa into main Nov 28, 2024
10 checks passed
@michaelpande michaelpande deleted the remove-nx branch November 28, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants