Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed focus order and styling for variable box #343

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

oyessb
Copy link
Contributor

@oyessb oyessb commented Nov 18, 2024

Changed focus order for variable box.
Added focus styling for chevron.
Changed style for select so it is not hidden for focus-visible state.

Copy link

cloudflare-workers-and-pages bot commented Nov 25, 2024

Deploying pxweb2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0997401
Status: ✅  Deploy successful!
Preview URL: https://e14ab52b.pxweb2.pages.dev
Branch Preview URL: https://feature-pxweb2-315-variableb.pxweb2.pages.dev

View logs

Copy link

sonarqubecloud bot commented Dec 2, 2024

Copy link
Contributor

@michaelpande michaelpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Har ikke testet det, kun lest koden

@oyessb oyessb merged commit 07bacf2 into main Dec 4, 2024
8 checks passed
@oyessb oyessb deleted the feature/PXWEB2-315-variablebox-focus-visible branch December 4, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants